Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore writing OperationKind during generation #53812

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jun 1, 2021

Thanks @alrz for pointing this out.

@333fred 333fred requested a review from a team as a code owner June 1, 2021 17:44
@333fred
Copy link
Member Author

333fred commented Jun 1, 2021

@dotnet/roslyn-compiler for a quick review. This hasn't actually affected any code yet, but it would be good to get it in quickly so it can flow into feature branches before people hit it.

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1) assuming that a local testing has been performed verifying the expected behavior.

@333fred 333fred enabled auto-merge (squash) June 1, 2021 18:05
@333fred 333fred disabled auto-merge June 1, 2021 18:10
@333fred
Copy link
Member Author

333fred commented Jun 1, 2021

@jaredpar for approval to merge into 16.11.

@333fred 333fred enabled auto-merge (squash) June 1, 2021 20:05
@333fred 333fred merged commit 7791927 into dotnet:release/dev16.11 Jun 1, 2021
@333fred 333fred deleted the release/dev16.11 branch June 1, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants