Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to full ngen for Roslyn binaries #53837

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Switch to full ngen for Roslyn binaries #53837

merged 1 commit into from
Jun 2, 2021

Conversation

genlu
Copy link
Member

@genlu genlu commented Jun 2, 2021

@genlu genlu requested review from tmat and a team June 2, 2021 19:13
@genlu genlu requested review from a team as code owners June 2, 2021 19:13
@genlu genlu enabled auto-merge June 2, 2021 19:24
333fred
333fred approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot wait to not have to worry about optprof data 😆

@tmat
Copy link
Member

tmat commented Jun 2, 2021

@333fred I think we would still care - the full NGEN uses optprof data to decide how to lay out the generated code.

@333fred
Copy link
Member

333fred commented Jun 2, 2021

@333fred I think we would still care - the full NGEN uses optprof data to decide how to lay out the generated code.

Well now I am sad again.

@genlu
Copy link
Member Author

genlu commented Jun 2, 2021

@333fred Hey, at least we won't see as many image size regressions :)

@genlu genlu disabled auto-merge June 2, 2021 20:24
@genlu genlu merged commit 5dc3c06 into dotnet:release/dev17.0-preview1-vs-deps Jun 2, 2021
@genlu genlu deleted the fullNgen branch June 2, 2021 20:47
@genlu genlu mentioned this pull request Jun 8, 2021
Merged
@genlu genlu mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genlu @tmat @333fred