Add FadingOptionsProvider #53873
Merged
Add FadingOptionsProvider #53873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Jun 4, 2021
davidwengier
approved these changes
Jun 4, 2021
|
@jinujoseph for 16.11 approval (I am in favor of this) |
|
Will approve once branch is open for 16.11.Preiew3 ( cc @rikki) |
Youssef1313
suggested changes
Jun 4, 2021
There was a problem hiding this comment.
Automation object needs to be updated for this option to be persisted correctly.
(Note: this suggestion will conflict with main later (due to #53102), but shouldn't be much of pain to resolve the conflict later on)
Thanks @Youssef1313! Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #53872
Without the OptionsProvider the fading options are not available from OOP and the default value of
trueis used instead.