Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for content type renames for aspx/cshtml/html files. #53954

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

ToddGrun
Copy link
Contributor

@ToddGrun ToddGrun commented Jun 8, 2021

These content type names are not yet submitted. Once they have been submitted, there will be a subsequent commit to only remove the old content type names.

These content type names are not yet submitted. Once they have been submitted, there will be a subsequent commit to only remove the old content type names.
@ToddGrun ToddGrun requested a review from a team as a code owner June 8, 2021 20:40
@NTaylorMullen
Copy link
Contributor

I'm so confused how your changes here broke anything lol:
image

@ToddGrun
Copy link
Contributor Author

ToddGrun commented Jun 8, 2021

Yeah, I'm not clear either. I thought I matched the existing formatting.


In reply to: 857205405

@davidwengier
Copy link
Contributor

I'm so confused how your changes here broke anything lol:

Looks like a space after the ||.

@ToddGrun
Copy link
Contributor Author

ToddGrun commented Jun 9, 2021

I assume the failing checks aren't known? If not, I'm a bit surprised that this change could have caused them.

@ToddGrun ToddGrun merged commit 2541044 into main Jun 9, 2021
@ghost ghost added this to the Next milestone Jun 9, 2021
@ToddGrun ToddGrun deleted the dev/toddgrun/ChangeWebToolsContentTypeNamesInMain branch June 9, 2021 19:21
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants