Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LSP integration tests in main-vs-deps #53985

Closed

Conversation

RikkiGibson
Copy link
Contributor

Related to #53972

Noticed these failing in merges to main-vs-deps and blocking auto-merge #53982. It's possible though that it was a random failure and that these are expected to pass and allow code to flow automatically.

@RikkiGibson RikkiGibson requested a review from a team as a code owner June 10, 2021 01:09
@RikkiGibson RikkiGibson changed the title Update azure-pipelines-integration-lsp.yml Disable LSP integration tests in main-vs-deps Jun 10, 2021
@RikkiGibson
Copy link
Contributor Author

Please take a look @dibarbet and let me know if this is reasonable or not.

@dibarbet
Copy link
Member

These should be already disabled for PR checks in the pipeline trigger page per the comment. I'm not sure why they're showing up on main-vs-deps PRs. Still looking to see why. But if we can't figure it out, the triggers section should be left as-is but the PR can be none.

@dibarbet
Copy link
Member

Ok so I figured out what is happening here. Lets look at this PR (#53982) which has a failing LSP integration test on a PR that is not supposed to even run the LSP integration tests. Note the comment only triggers in the UI:
image

The LSP integration test pipeline is configured to run after a commit is merged into Roslyn.
@RikkiGibson previously merged this pr - #53971 which triggered this post-commit build (which failed) - https://dev.azure.com/dnceng/public/_build/results?buildId=1179842&view=results

Now that we're merging the same commit into a new branch (#53982) the checks are picking up the old post commit build. It doesn't appear to be actually running anything, just showing it on the UI.

I have no idea how to fix this, it seems like a bug in the azure devops checks logic.

@RikkiGibson RikkiGibson marked this pull request as draft June 10, 2021 17:28
@RikkiGibson RikkiGibson deleted the dev/rigibson/disable-integration-lsp branch June 24, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants