Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WatchHotReloadService to specify runtime apply-update capabilities #54012

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

pranavkm
Copy link
Contributor

Contributes to dotnet/aspnetcore#33402

@pranavkm
Copy link
Contributor Author

@tmat / @davidwengier I was able to use this change to get it working with dotnet-watch. Here's the associated PR in the SDK: dotnet/sdk#18214.

@pranavkm pranavkm marked this pull request as ready for review June 11, 2021 21:41
@pranavkm pranavkm requested review from a team as code owners June 11, 2021 21:41
@pranavkm
Copy link
Contributor Author

@davidwengier / @tmat does this need any additional changes?

Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@pranavkm pranavkm merged commit a579702 into main-vs-deps Jun 14, 2021
@ghost ghost added this to the Next milestone Jun 14, 2021
@pranavkm pranavkm deleted the prkrishn/add-capability branch June 14, 2021 21:38
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
tmat pushed a commit to tmat/roslyn that referenced this pull request Jul 22, 2021
davidwengier pushed a commit to davidwengier/roslyn that referenced this pull request Jul 23, 2021
tmat added a commit that referenced this pull request Jul 23, 2021
…ies (#54012) (#55058)

Contributes to dotnet/aspnetcore#33402

Co-authored-by: Pranav K <prkrishn@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants