Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding the AsyncMethodBuilder on methods #54033

Merged
merged 28 commits into from
Jun 24, 2021
Merged

Allow overriding the AsyncMethodBuilder on methods #54033

merged 28 commits into from
Jun 24, 2021

Commits on Jun 11, 2021

  1. Allow AsyncMethodBuilder on method

    @jcouv
    jcouv committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    78a89b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Allow returning a non-task-like type

    @jcouv
    jcouv committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    f084cb2 View commit details
    Browse the repository at this point in the history

  2. Relax accessibility requirements for overrides

    @jcouv
    jcouv committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    e1f1d41 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Factor extension methods

    @jcouv
    jcouv committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    a39ee15 View commit details
    Browse the repository at this point in the history

  2. Fix nullability scenario

    @jcouv
    jcouv committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    e4ab3c3 View commit details
    Browse the repository at this point in the history

  3. Fix lambda scenario with non-task-like return type

    @jcouv
    jcouv committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    72cbc01 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @jcouv
    jcouv committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    3e9518b View commit details
    Browse the repository at this point in the history

  5. Disallow non-task-like return type after all

    @jcouv
    jcouv committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2a3fdf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Validate ignored builder type

    @jcouv
    jcouv committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    869671b View commit details
    Browse the repository at this point in the history

  2. use TryCreate

    @jcouv
    jcouv committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    22b5373 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'dotnet/main' into async-builder

    @jcouv
    jcouv committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    8ac378a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. hasErros

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2e7ad79 View commit details
    Browse the repository at this point in the history

  2. Factor extension method

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4375aea View commit details
    Browse the repository at this point in the history

  3. using

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    43416a2 View commit details
    Browse the repository at this point in the history

  4. Revert "Disallow non-task-like return type after all" 

    This reverts commit 2a3fdf1.
    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d5c0a27 View commit details
    Browse the repository at this point in the history

  5. Revert "Validate ignored builder type" 

    This reverts commit 869671b.
    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f7900d8 View commit details
    Browse the repository at this point in the history

  6. Restore tests

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e7ed4e3 View commit details
    Browse the repository at this point in the history

  7. Remove validation on return type

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    af160e2 View commit details
    Browse the repository at this point in the history

  8. Remove builder/factory indirection

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4218507 View commit details
    Browse the repository at this point in the history

  9. tweaks

    @jcouv
    jcouv committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ee207cb View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Address feedback

    @jcouv
    jcouv committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ec32fb2 View commit details
    Browse the repository at this point in the history

  2. Merge commit '9bcaddccfefc7d8e1804440419c17806e9ac9f27' into async-bu… 

    …ilder
    @jcouv
    jcouv committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9637282 View commit details
    Browse the repository at this point in the history

  3. Integrate explicit return types and builder overrides

    @jcouv
    jcouv committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7da7da7 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'dotnet/main' into async-builder

    @jcouv
    jcouv committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    457aac7 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'dotnet/main' into async-builder

    @jcouv
    jcouv committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3268386 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Adjust error code in tests

    @jcouv
    jcouv committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    9440d0f View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @jcouv
    jcouv committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a576b8c View commit details
    Browse the repository at this point in the history

  3. typo

    @jcouv
    jcouv committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    36b5a5d View commit details
    Browse the repository at this point in the history