Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing telemetry message #54046

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

ryzngard
Copy link
Contributor

Update the VSTelemetryLogger to include the message property of LogMessage if the message is not a KeyValueMessage

…ssage if the message is not a KeyValueMessage
@ryzngard ryzngard requested a review from a team as a code owner June 11, 2021 21:14
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this - but we'll probably start getting a lot more telemetry than before (just looking at all the usages of https://sourceroslyn.io/#Microsoft.CodeAnalysis.Workspaces/Logger.cs,18836a2d7350ee49)

Are there any that we should be removing, or is the plan to just see what new events we get and suppress later?

@ryzngard
Copy link
Contributor Author

I'm OK with this - but we'll probably start getting a lot more telemetry than before (just looking at all the usages of https://sourceroslyn.io/#Microsoft.CodeAnalysis.Workspaces/Logger.cs,18836a2d7350ee49)

Are there any that we should be removing, or is the plan to just see what new events we get and suppress later?

I should probably move LogBlock to follow same rules as Log. I added LogLevel specifically so we could provide logging on any kind of message, and the logger provides how. VSTelemetry should send anything >= Information

@ryzngard ryzngard enabled auto-merge June 14, 2021 20:03
@ryzngard ryzngard merged commit f31d8b6 into dotnet:main Jun 14, 2021
@ghost ghost added this to the Next milestone Jun 14, 2021
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants