Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for disabling structure guides #54079

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Restore support for disabling structure guides #54079

merged 2 commits into from
Jun 15, 2021

Conversation

sharwell
Copy link
Member

Fixes #54078

@sharwell sharwell requested a review from a team as a code owner June 14, 2021 17:00
jmarolf
jmarolf approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell is there no mechanism to test this?

@sharwell
Copy link
Member Author

@jmarolf There were no tests for IStructureTag.Type previously, but I added several including ones to cover this change.

@sharwell sharwell mentioned this pull request Jun 15, 2021
Closed
@jinujoseph jinujoseph added this to the 16.11 milestone Jun 15, 2021
@jinujoseph
Copy link
Contributor

This is targeted for 16.11.Preview3

@sharwell sharwell enabled auto-merge June 15, 2021 17:05
@sharwell sharwell merged commit b06f360 into dotnet:release/dev16.11 Jun 15, 2021
@sharwell sharwell deleted the structure-tag branch June 15, 2021 20:49
This was referenced Jun 23, 2021
Closed
Closed
@sharwell sharwell mentioned this pull request Sep 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
Approved to merge Area-IDE
Projects
None yet
Milestone
16.11
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @jinujoseph @jmarolf