Pack error codes. Disallow UnmanagedCallersOnly for abstract static methods. #54118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
approved these changes
Jun 15, 2021
| @@ -6697,4 +6697,8 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ | |||
| <data name="ERR_AbstractConversionNotInvolvingContainedType" xml:space="preserve"> | |||
| <value>User-defined conversion in an interface must convert to or from a type parameter on the enclosing type constrained to the enclosing type</value> | |||
| </data> | |||
| <data name="ERR_InterfaceImplementedByUnmanagedCallersOnlyMethod" xml:space="preserve"> | |||
| <value>'UnmanagedCallersOnly' method '{0}' cannot implement interface member '{1}' in type '{2}'</value> | |||
There was a problem hiding this comment.
It looks like {2} is included in this diagnostic because it may not be the same as the containing type of {0}. Is that correct? #Resolved
There was a problem hiding this comment.
It looks like {2} is included in this diagnostic because it may not be the same as the containing type of {0}. Is that correct?
Correct.
|
@dotnet/roslyn-infrastructure It looks like all CI jobs succeeded for this PR, but the status isn't updated on the PR page, which is blocking merging. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
AzDO pipelines all succeeded here but we were hitting the bug where it's not updating GH status. Forced merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.