Use segmented collection for faster declaration cache #54146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Jun 17, 2021
src/Compilers/Core/Portable/Collections/DictionaryExtensions.cs
Outdated
Show resolved
Hide resolved
Ideally ImmutableSegmentedHashSet<string> would be used, but this type is not currently available. As an interim solution, ImmutableSegmentedDictionary<string, VoidResult> is used as a set. See https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1343268
333fred
approved these changes
Jun 17, 2021
|
@dotnet/roslyn-compiler for a second review |
jaredpar
approved these changes
Jun 17, 2021
ghost
added this to the 
RikkiGibson
reviewed
Jun 17, 2021
| { | ||
| public static bool TryAdd<T>( | ||
| this ImmutableSegmentedDictionary<T, VoidResult>.Builder dictionary, | ||
| T value) |
There was a problem hiding this comment.
Would it be appropriate to name this parameter 'key'?
There was a problem hiding this comment.
This is specifically implemented for treating a dictionary with VoidResult values as a set. The name could go either way, but hopefully a proper set type replaces this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally
ImmutableSegmentedHashSet<string>would be used, but this type is not currently available. As an interim solution,ImmutableSegmentedDictionary<string, VoidResult>is used as a set.This addresses 10-20% of the allocation load in AB#1343268, where GC is a significant contributor to slowness.