Avoid returning default from MethodSymbol.Parameters #54179
Conversation
|
@dotnet/roslyn-compiler For the second review. |
| @@ -106,7 +106,7 @@ public sealed override ImmutableArray<ParameterSymbol> Parameters | |||
| { | |||
| if (_parameters.IsDefault) | |||
| { | |||
| ImmutableInterlocked.InterlockedCompareExchange(ref _parameters, MakeParameters(), default(ImmutableArray<ParameterSymbol>)); | |||
| ImmutableInterlocked.InterlockedInitialize(ref _parameters, MakeParameters()); | |||
There was a problem hiding this comment.
Can you help me understand how these two lines are different? I'm missing the distinction here.
There was a problem hiding this comment.
➡️ They are semantically identical. The simpler form allows a reader to understand the behavior without the mental burden of relating the third parameter of InterlockedCompareExchange to the default state for the field.
ghost
added this to the 
|
Merged/squashed. Will take another look at https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1341051 with this new baseline. Thanks |
|
@jcouv Please do not squash merge pull requests submitted by me. I meticulously separated this pull request into four distinct changes with the intent they would be preserved as such. Thanks! |
|
@sharwell Sorry about that. |
|
@jcouv no problem glad it's merged ! |
Review commit-by-commit recommended.
This change ensures that all implementations of
MethodSymbol.Parametersreturn a non-default array, excluding cases whereLazyMethodChecksfails to initialize parameters. It also cleans up some initialization sites to use current practices.