Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick the ExplicitInterfaceImplemetation fix #54180

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Cherry-pick the ExplicitInterfaceImplemetation fix #54180

merged 4 commits into from
Jun 23, 2021

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Jun 17, 2021

Port this fix to 16.11
#53984

@Cosifne Cosifne requested a review from a team as a code owner June 17, 2021 18:13
@Cosifne
Copy link
Member Author

Cosifne commented Jun 17, 2021

@jinujoseph @vatsalyaagrawal
This is just a one line fix for the inheritance margin. Without this fix inheritance margin won't be created for explict interface implementation.
So I feel it will be great to check this change to 16.11

@Cosifne
Copy link
Member Author

Cosifne commented Jun 22, 2021

OMG this is forgotten for a long time.
@davidwengier Could you give this a quick approval. it's the same as #53984

@CyrusNajmabadi
Copy link
Member

Why do we need to backport this to 16.11? seems like a minor issue?

@Cosifne
Copy link
Member Author

Cosifne commented Jun 22, 2021

Why do we need to backport this to 16.11? seems like a minor issue?

@CyrusNajmabadi
I believe explicit implementation is used widely, and the fix is pretty easy and low-risk.
Do we only checked in big reliability fix to 16.11 now?

@CyrusNajmabadi
Copy link
Member

Do we only checked in big reliability fix to 16.11 now?

I'm not sure what the 16.11 bar is at currently. Are we in any sort of QB mode now?

@Cosifne
Copy link
Member Author

Cosifne commented Jun 22, 2021

Do we only checked in big reliability fix to 16.11 now?

I'm not sure what the 16.11 bar is at currently. Are we in any sort of QB mode now?

@CyrusNajmabadi
I think 16.11 is in M1 mode. (required approval from Jinu or Vatsalya) and I have already explained this to Jinu

@Cosifne Cosifne merged commit 141ac4f into dotnet:release/dev16.11 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Approved to merge Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cosifne @CyrusNajmabadi @davidwengier @jinujoseph