Allow snippet format in XAML compeltion #54183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgoertz-msft @dibarbet Could you please help to take a look? |
dibarbet
reviewed
Jun 17, 2021
| @@ -46,6 +46,7 @@ internal class XamlInProcLanguageClient : AbstractInProcLanguageClient | |||
|
|
|||
| /// <summary> | |||
| /// Gets the name of the language client (displayed in yellow bars). | |||
| /// When updating the string of Name, please make sure to update the same string in Microsoft.VisualStudio.LanguageServer.Client.ExperimentalSnippetSupport.AllowList | |||
There was a problem hiding this comment.
@NTaylorMullen wanted to check, is snippet support being expanded outside of razor
There was a problem hiding this comment.
Yeah we have already chatted with Taylor about adding this support in XAML.
| @@ -27,5 +27,6 @@ internal class XamlCompletionItem | |||
| public ISymbol Symbol { get; set; } | |||
| public XamlEventDescription? EventDescription { get; set; } | |||
| public bool RetriggerCompletion { get; set; } | |||
| public bool InsertSnippet { get; set; } | |||
dibarbet
approved these changes
Jun 17, 2021
NTaylorMullen
approved these changes
Jun 17, 2021
LinglingTong
force-pushed
the
dev/ltong/snippetformat
branch
from
ea5f236
to
bccf462
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives XAML language service the capability to tell LSP completion whether the inset text format is snippet or just plaintext. So we will be able to do completions like inserting ="|" when committing a XAML attribute.