Track used project reference by their file name #54280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Jun 22, 2021
src/EditorFeatures/Test/UnusedReferences/UnusedReferencesRemoverTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Remove the project file name now that we've identified it. | ||
| usedProjectFileNames.ExceptWith(projectAssemblyFileNames); |
There was a problem hiding this comment.
Does this need to happen when we add to the unusedReferenceBuilder as well?
There was a problem hiding this comment.
We don't because the check that adds a project to the unusedReferenceBuilder ensures that usedProjectFileNames doesn't contain any of the projectAssemblyFileNames.
Co-authored-by: Andrew Hall <ryzngard@live.com>
|
@vatsalyaagrawal For 16.11 Preview 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54262
Used project references are reported differently that package references by the compiler. We can track them separately and match them with referenced projects by their filename.