Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a couple of APIs from the generator driver into extension methods #54285

Merged

Conversation

chsienki
Copy link
Contributor

Fixes #54092

Simple refactoring moving some APIs from the generator driver into extension methods. Agreed as part of earlier API review, but missed from earlier changes.

@chsienki chsienki requested review from a team as code owners June 22, 2021 17:12
@chsienki
Copy link
Contributor Author

@dotnet/roslyn-compiler for review please.

@chsienki chsienki closed this Jun 23, 2021
@chsienki chsienki reopened this Jun 23, 2021
@chsienki chsienki merged commit 4792724 into dotnet:main Jun 24, 2021
@ghost ghost added this to the Next milestone Jun 24, 2021
@chsienki chsienki deleted the source-generators/move-apis-to-extension branch June 24, 2021 02:07
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source generator Wrap/GetType methods should be extensions on the type
4 participants