Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect unit test code sample in source generator docs #54320

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Fix incorrect unit test code sample in source generator docs #54320

merged 2 commits into from
Jul 14, 2021

Conversation

scharnyw
Copy link
Contributor

The GeneratedSources property is defined on the Microsoft.CodeAnalysis.Testing.ProjectState class, not the Microsoft.CodeAnalysis.CSharp.Testing.CSharpSourceGeneratorTest class. So the sample code provided in source generator cookbook was incorrect and did not compile. Fixed by moving it to the correct place.

sharwell
sharwell approved these changes Jun 23, 2021
View reviewed changes
docs/features/source-generators.cookbook.md Outdated Show resolved Hide resolved
@scharnyw scharnyw requested a review from sharwell June 30, 2021 03:10
jcouv
jcouv approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Jul 14, 2021
@jcouv jcouv merged commit 2946c61 into dotnet:main Jul 14, 2021
@ghost ghost added this to the Next milestone Jul 14, 2021
@jcouv
Copy link
Member

jcouv commented Jul 14, 2021

Merged/squashed. Thanks @scharnyw

@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@jcouv jcouv jcouv approved these changes

@sharwell sharwell Awaiting requested review from sharwell

Assignees

@jcouv jcouv

Labels
Area-Compilers Documentation New Feature - Source Generators Source Generators
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.
5 participants
@scharnyw @jcouv @sharwell @Youssef1313 @allisonchou