Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdatedTypes to WatchHotReloadService.Update #54340

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 23, 2021

Fixes #54336

@tmat tmat requested a review from a team as a code owner June 23, 2021 20:08
@tmat
Copy link
Member Author

tmat commented Jun 23, 2021

@davidwengier @pranavkm

Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy!

@@ -762,7 +761,7 @@ public async ValueTask<SolutionUpdate> EmitSolutionUpdateAsync(Solution solution
pdbStream.ToImmutableArray(),
projectChanges.LineChanges,
updatedMethodTokens,
updatedTypes: ImmutableArray<int>.Empty,
updatedTypeTokens,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK :(

@tmat tmat merged commit f814914 into dotnet:main Jun 23, 2021
@ghost ghost added this to the Next milestone Jun 23, 2021
@tmat tmat deleted the HRServiceUpdatedTypes branch June 23, 2021 22:33
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchHotReloadService.EmitSolutionUpdateAsync should include the list of changed types
4 participants