Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IExpeditableDelaySource and TimeSpan in additional locations #54344

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Use IExpeditableDelaySource and TimeSpan in additional locations #54344

merged 5 commits into from
Jun 23, 2021

Conversation

sharwell
Copy link
Member

  • Use IExpeditableDelaySource instead of configurable waits in WorkCoordinatorTests. This removes 6 manually-configured options while reducing the execution time for the test class from ~17 seconds to ~6 seconds.
  • Use TimeSpan instead of int for additional representation of time spans.

@sharwell sharwell requested a review from a team as a code owner June 23, 2021 21:40
@sharwell sharwell enabled auto-merge June 23, 2021 21:48
@sharwell sharwell merged commit b47268b into dotnet:main Jun 23, 2021
@ghost ghost added this to the Next milestone Jun 23, 2021
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
@sharwell sharwell deleted the timespan branch January 13, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @CyrusNajmabadi @RikkiGibson