Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IVT for UnitTestingHostReloadService #54366

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Add IVT for UnitTestingHostReloadService #54366

merged 3 commits into from
Jun 25, 2021

Conversation

vritant24
Copy link
Member

  1. Add IVT to use the UnitTestingHostReloadService
  2. Update API to give a list of capabilities
  3. Update API to dictate whether or not to commit updates

@vritant24 vritant24 requested a review from a team as a code owner June 24, 2021 20:27
@vritant24
Copy link
Member Author

tagging @tmat

@vritant24
Copy link
Member Author

vritant24 commented Jun 25, 2021 •
edited
Loading

Addressed comments

davidwengier
davidwengier approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge once the build is green.

@davidwengier davidwengier enabled auto-merge (squash) June 25, 2021 06:07
@vritant24
Copy link
Member Author

@davidwengier looks like the ci build failed due to an agent availability issue? Is there a way to re-run it?

@tmat
Copy link
Member

tmat commented Jun 25, 2021

Done

@davidwengier davidwengier merged commit 2384855 into dotnet:main Jun 25, 2021
@ghost ghost added this to the Next milestone Jun 25, 2021
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@vritant24 @tmat @davidwengier @RikkiGibson