Enable experiment for Inheritance Margin #54371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
force-pushed
the
dev/shech/InheritanceMarginExperiment
branch
from
c9bb51c
to
219459a
Compare
ryzngard
reviewed
Jun 24, 2021
src/VisualStudio/CSharp/Impl/Options/AdvancedOptionPageControl.xaml.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Jun 24, 2021
src/EditorFeatures/Core/InheritanceMargin/AbstractInheritanceMarginService.cs
Outdated
Show resolved
Hide resolved
Cosifne
force-pushed
the
dev/shech/InheritanceMarginExperiment
branch
from
219459a
to
87735a2
Compare
Cosifne
commented
Jun 24, 2021
| @@ -99,10 +112,14 @@ protected override IEnumerable<SnapshotSpan> GetSpansToTag(ITextView textView, I | |||
| return; | |||
| } | |||
|
|
|||
| var inheritanceMemberItems = await inheritanceMarginInfoService.GetInheritanceMemberItemsAsync( | |||
| var inheritanceMemberItems = ImmutableArray<InheritanceMarginItem>.Empty; | |||
| using (Logger.LogBlock(FunctionId.InheritanceMargin_GetInheritanceMemberItems, cancellationToken, LogLevel.Information)) | |||
There was a problem hiding this comment.
Add a telemtry to know how long it takes to get all the inheritance info back.
Cosifne
force-pushed
the
dev/shech/InheritanceMarginExperiment
branch
from
fb69f1d
to
5cb76b7
Compare
|
Tag @ryzngard for another review : ) |
Cosifne
force-pushed
the
dev/shech/InheritanceMarginExperiment
branch
from
14e86b7
to
a935a8d
Compare
ryzngard
approved these changes
Jun 28, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #53881 states, starts AB test for inheritance margin