Make insertion a stage of the official build #54376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Jun 25, 2021
JoeRobich
reviewed
Jun 25, 2021
azure-pipelines-official.yml
Outdated
| type: string | ||
| default: default | ||
|
|
||
| - name: IbcSourceBranchName |
There was a problem hiding this comment.
I am not certain this parameter works anymore. I've seen reference to a _IbcSourceBranchName tho.
There was a problem hiding this comment.
Perhaps arcade targets pick it up in the environment variables. I kicked this build using the variable, let's see if it has the desired effect. https://dev.azure.com/dnceng/internal/_build/results?buildId=1206551&view=results
JoeRobich
reviewed
Jun 25, 2021
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
JoeRobich
approved these changes
Jun 25, 2021
|
These changes don't affect any of the CI that runs on PRs, so I'm going to just merge this to get things flowing. |
333fred
added a commit
that referenced
this pull request
Jun 25, 2021
…ures/caller-argument-expression * upstream/main: (492 commits) Add nullable ref annotations to SyntaxFactory (#54199) Add 'replace' APIs and hook them up to the IDE (#54270) Allow implicit implementation of non-public interface members (#54182) Make insertion a stage of the official build (#54376) Cleanup Remove unused property Simplify glyph computation Report all-empty top level statements. (#54385) Calculate TypeParameterKind based on the container type (#54200) vert not roaming Split tests Multple matches Report as we get results Fixup tests Update tests Avoid thread dependency in VirtualMemoryNotificationListener constructor Fast progression search. Add LanguageVersion 10 (#54359) Sure, why not ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so we no longer need a separate release pipeline to create insertions and instead the insertion just happens as a stage of the official build. The stage can be run repeatedly as many times as desired even if it already succeeded.
Also, this modifies the official build to include the parameters in yaml, rather than specifying them via the web UI (eventually, we would want to go into the web UI and delete the "old" versions of the variables in there.)
Here's a build which uses a change very similar to what's in this branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=1204839&view=results
It's hard to tell for certain due to possible delays in symbol publishing, but this change does have the potential to tighten up our insertion loop by 20-30 minutes because it doesn't wait for unnecessary validation/publishing stages that occur after the actual build stage.
cc @JoeRobich @dotnet/roslyn-infrastructure