Create default option for lsp pull diagnostics to allow it to be switched on via feature flag #54411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched on via feature flag
dibarbet
added
Area-IDE
LSP
dibarbet
commented
Jun 26, 2021
| [ExportWorkspaceServiceFactory(typeof(IDiagnosticModeService), ServiceLayer.Host), Shared] | ||
| internal class VisualStudioDiagnosticModeServiceFactory : IWorkspaceServiceFactory | ||
| [ExportWorkspaceServiceFactory(typeof(IDiagnosticModeService), ServiceLayer.Default), Shared] | ||
| internal class DefaultDiagnosticModeServiceFactory : IWorkspaceServiceFactory |
There was a problem hiding this comment.
there didn't seem to be really anything in the vs service that was VS specific, so moving down and making default to allow me to test these code paths.
davidwengier
approved these changes
Jun 26, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a default option so that we can turn on the option via a feature flag, but still allow users to specifically opt-out (and not override that setting if they do).