Fix add parameter for records #54427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jun 27, 2021
Comment on lines
+2119
to
+2121
| case SyntaxKind.RecordDeclaration: | ||
| case SyntaxKind.RecordStructDeclaration: | ||
| return ((RecordDeclarationSyntax)declaration).WithParameterList((ParameterListSyntax)list); |
There was a problem hiding this comment.
Does someone think it's worth adding a validation in debug mode that uses reflection to make sure new nodes are handled? (This doesn't apply to this method only - there are many that usually get affected)
jinujoseph
added
the
Community
CyrusNajmabadi
approved these changes
Jun 28, 2021
ghost
added this to the 
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54408