Use primitives for batching requests in NavBars #54433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jun 28, 2021
| /// to show all items. | ||
| /// The last fully computed model. | ||
| /// </summary> | ||
| private NavigationBarModel _model_OnlyAccessOnUIThread; |
There was a problem hiding this comment.
This gets cleaner once #54443 goes in. Then we don't need to have state for this and can just pass this value through our work queue.
CyrusNajmabadi
commented
Jun 28, 2021
src/EditorFeatures/Core/Implementation/NavigationBar/NavigationBarController.cs
Outdated
Show resolved
Hide resolved
…nBarController.cs
CyrusNajmabadi
commented
Jun 28, 2021
| void Disconnect(); | ||
|
|
||
| void SetWorkspace(Workspace? newWorkspace); | ||
| } |
There was a problem hiding this comment.
removed as there's no need to listen for the workspace (the event sources take care of that). And instead of .Disconnect, this can just be IDisposable.
CyrusNajmabadi
commented
Jun 28, 2021
| @@ -97,41 +132,17 @@ internal partial class NavigationBarController : ForegroundThreadAffinitizedObje | |||
| TaggerEventSources.OnWorkspaceRegistrationChanged(subjectBuffer)); | |||
There was a problem hiding this comment.
this is the line that notifies us when our buffer is attached to a workspace. so no need for other components to tell us.
…udioTodoCommentsService.cs
…abadi/roslyn into asyncBatchingWorkQueue
…entStorageTests.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
|
Azure Pipelines successfully started running 4 pipeline(s). |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #54432. That should go in first.