Enable EnC diagnostics in LSP #54500
Conversation
dibarbet
added
Area-IDE
LSP
Thought that might be the case. We're probably serializing things differently |
| return _lazyCompileTimeSolution; | ||
|
|
||
| // Only re-use when the lazy solution is from the same branch as the requested solution. | ||
| if (_lazyCompileTimeSolution.BranchId == designTimeSolution.BranchId) |
There was a problem hiding this comment.
yeah that seems reasonable, currently it ends up flip-flopping depending on how the requests come in. I'll have one cached snapshot for the primary branch and another item cached for a different branch (note that the branchId for the LSP solution changes on every text change since we fork from the workspace each time)
There was a problem hiding this comment.
@tmat updated to include a cache for the primary branch as well as another snapshot cache for forked requests
dibarbet
force-pushed
the
enc_lsp_diagnostics
branch
2 times, most recently
from
5f56712
to
96c8859
Compare
|
Merging to unblock insertion. |
Adds support for EnC diagnostics via LSP
Note that there seems to still be an issue on the Razor side with squiggle color (I verified we are returning the appropriate EnC tag for Razor diagnostics) cc @NTaylorMullen
