Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move suggestion options down to EditorFeatures lib. #54546

Closed
wants to merge 1 commit into from
Closed

Move suggestion options down to EditorFeatures lib. #54546

wants to merge 1 commit into from

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners July 1, 2021 22:12
ryzngard
ryzngard approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK if this change compiles then :shipit:

@RikkiGibson
Copy link
Contributor

@CyrusNajmabadi Please target release/dev17.0-vs-deps with this change.

RikkiGibson
RikkiGibson requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until the base branch is fixed.

@dibarbet dibarbet mentioned this pull request Jul 1, 2021
Merged
@RikkiGibson
Copy link
Contributor

Superseded by #54549

@RikkiGibson RikkiGibson closed this Jul 1, 2021
auto-merge was automatically disabled July 1, 2021 23:31

Pull request was closed

@CyrusNajmabadi CyrusNajmabadi deleted the moveOptionsDown branch September 17, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson requested changes

@davidwengier davidwengier davidwengier approved these changes

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @RikkiGibson @ryzngard @davidwengier