Set [Skip-SymbolCheck] suffix in insertion tool #54580
Conversation
Is there a check at a later point (that also gives us time to fix the issue) telling us if we have a problem with symbols we've previously uploaded? |
Everyone after us who doesn't skip symbol checks will get a check failure in their PRs, which will get blamed on us, I think. It's also worth noting that symbol publishing can happen at any time, even after the product ships. As long as we retain the symbols for our official builds (e.g. by publishing them as an artifact, as I think we currently do) we can always go back, grab the symbols and publish them. |
Good to know
Yep, was mainly concerned if we broke our symbols somehow and so the symbols we uploaded were incorrect and then didn't realize. But I'm not sure if symbol check does that deep of a validation |
Depends on dotnet/roslyn-tools#1029
Symbol checks are too slow for us to be able to insert as quickly as we'd like. Currently we artificially slow down the insertion by making the insert stage depend on the publish_using_darc stage. This change makes it so we just always skip the symbol check in insertions, which we've judged to be low-risk, and make the insert stage depend only on the build stage. This change makes our insertions show up ~30 minutes faster.