Minor record ToString improvements #54630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2021 15:03
I don't know exactly what else must be done to ensure that Append(char) will be successfully referred to
All the headers for each new printable member are merged into one compiled string
jcouv
added
the
Community
jcouv
reviewed
Jul 12, 2021
| block.Add(makeAppendString(F, builder, " = ")); | ||
| var memberHeader = $"{member.Name} = "; | ||
| if (i > 0) | ||
| memberHeader = ", " + memberHeader; |
There was a problem hiding this comment.
nit: please use braces to match rest of the code
jcouv
reviewed
Jul 12, 2021
| @@ -87,6 +87,10 @@ static BoundStatement makeAppendString(SyntheticBoundNodeFactory F, BoundLocal b | |||
| { | |||
| return F.ExpressionStatement(F.Call(receiver: builder, F.WellKnownMethod(WellKnownMember.System_Text_StringBuilder__AppendString), F.StringLiteral(value))); | |||
| } | |||
| static BoundStatement makeAppendChar(SyntheticBoundNodeFactory F, BoundLocal builder, char value) | |||
There was a problem hiding this comment.
nit: empty line to separate methods would be desirable
jcouv
reviewed
Jul 12, 2021
| @@ -4903,25 +4911,21 @@ public void ToString_TopLevelRecord_OneField_ValueType() | |||
|
|
|||
| v.VerifyIL("C1." + WellKnownMemberNames.PrintMembersMethodName, @" | |||
| { | |||
| // Code size 50 (0x32) | |||
| // Code size 38 (0x26) | |||
There was a problem hiding this comment.
I'd say the reduction in IL size is probably the biggest benefit. I think that's nice. Thanks
jcouv
approved these changes
Jul 12, 2021
333fred
approved these changes
Jul 13, 2021
ghost
added this to the 
|
Merged/squashed. Thanks @alfasgd for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54600
This implements all the mentioned improvements
Append(string)Append(char)Additionally, also changes some tests to comfort to the new changes to the emitted IL and diagnostics.
Effects
As measured from the diffs of the expected emitted IL tests:
ToStringgets a -6 byte code sizePrintMembersgets -12 byte code size for 1 member, -36 for 2, expected formula:-12 - 24 * (members - 1)