Handle FAR for global suppressions in a consistent fashion #54641
Conversation
CyrusNajmabadi
force-pushed
the
farRefactorings
branch
from
067a725
to
034c8f1
Compare
CyrusNajmabadi
force-pushed
the
farRefactorings
branch
from
034c8f1
to
20984e3
Compare
| /// Finds all the documents in the provided project that contain the requested string | ||
| /// values |
There was a problem hiding this comment.
"requested string values"
What requested string values? This just finds where ContainsGlobalAttribues is true
| docCommentId, findInGlobalSuppressions, cancellationToken); | ||
| } | ||
|
|
||
| [PerformanceSensitive("https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224834", OftenCompletesSynchronously = true)] |
There was a problem hiding this comment.
Unsure why this is no longer perf sensitive
| protected static async ValueTask<ImmutableArray<FinderLocation>> FindReferencesInDocumentUsingIdentifierAsync( | ||
| ISymbol _, |
There was a problem hiding this comment.
Why take a symbol if it's not used?
Assuming this is a behavior change. With all of the FAR changes I'm not 100% sure if this is just a refactoring keeping old behavior. If it is, please add that to the PR description :) |
This area is already extensively tested. This doesn't change behavior. It just updates the implementation to follow the general patterns of hte rest of the FAR code and it removes some ugly special casing htat was happening before. I've pulled this out of a larger set of refactorings i'm making as i would like to keep the large one under control. |
It will be used in a followup PR. If i remove, i need to fixup all callsties, but then i'm going to be adding it back in, so i'll just be undoing that. |
|
@dotnet/roslyn-compiler for a tiny compiler change. |
ghost
added this to the 
No description provided.