Capture file content on open instead of save #54643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jul 6, 2021
ryzngard
approved these changes
Jul 6, 2021
ghost
added this to the
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 7, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 8, 2021
* upstream/main: (559 commits) Remove a few unused error codes (dotnet#54663) Use specific error message for wrong arity in async builder (dotnet#54632) Update azure-pipelines-richnav.yml (dotnet#54662) Capture file content on open instead of save (dotnet#54643) Add docs Further FAR simplifications Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636) move server name outside of loop Fix functionid Reduce telemetry output from find document in workspace Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) Feedback Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) No need to specialized logic for determining set of projects to search Defer group computation till reporting time Handle FAR for global suppressions in a consistent fashion Update status for enhanced `#line` directive (dotnet#54581) Split IOperationTests into one part per type [LSP] Revert semantic tokens change in main (dotnet#54570) Add exceptionutilities unreachable to catch blocks that should not be hit ...
ryzngard
added a commit
that referenced
this pull request
Jul 8, 2021
Capture file content on open instead of save (#54643)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnC analyzer needs to compare the original content of a source file, which the compiler used to emit the baseline dll, with the current snapshot.
To ensure the original content is compared, the EnC analyzer compares the checksum of the document with the checksum stored in PDB. If they don't match the document is "out of sync" and analysis can't be performed until the analyzer gets ahold of the original content.
The solution snapshot captured at the start of debugging or Hot Reload session doesn't necessarily reflect the original content since workspace is updated based on file watcher events and updates in editor buffers.
Previously we attempted to capture the original file content when an editor buffer is saved (looking at the content on disk before the save). However the current implementation is just best effort (race condition) and the editor currently does not provide APIs that would give us a chance to asynchronously read the content of the file before the save operation without blocking UI.
Instead, we check the checksum of the content of a source file on disk when the file is opened.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1348122