Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded prototype #54645

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Remove unneeded prototype #54645

merged 1 commit into from
Jul 7, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 6, 2021 •
edited
Loading

Proposal: dotnet/csharplang#287
Test plan: #52745

I think current behavior matches LDM decision:
https://github.com/dotnet/csharplang/blob/d91eab3660ef80159cecd76ad89456cc2607cadd/meetings/2021/LDM-2021-06-14.md#span-of-the-expression

Conclusion
Option 3: we go from the start of real C# executable code to the end of the expression, not including any leading or trailing trivia.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 6, 2021 22:26
@jcouv
Copy link
Member

jcouv commented Jul 6, 2021 •
edited
Loading

Do we have other tests that cover the behavior described by LDM decision? Or is that tracked as a follow-up somewhere?

In reply to: 875138982

@jcouv jcouv self-assigned this Jul 6, 2021
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jul 6, 2021 •
edited
Loading

Do we have other tests that cover the behavior described by LDM decision? Or is that tracked as a follow-up somewhere?

There are other tests for comments.
TestGoodCallerArgumentExpressionAttribute_ExpressionHasTrivia

jcouv
jcouv approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv merged commit fd2a03f into dotnet:features/caller-argument-expression Jul 7, 2021
@Youssef1313 Youssef1313 deleted the patch-12 branch July 7, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @jcouv @cston