Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address FileScopedNamespaces test plan review #54669

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Address FileScopedNamespaces test plan review #54669

merged 5 commits into from
Jul 9, 2021

Conversation

RikkiGibson
Copy link
Contributor

Test plan: #49000

Addresses some items added during test plan review.

@RikkiGibson RikkiGibson requested review from a team as code owners July 7, 2021 23:36
@RikkiGibson
Copy link
Contributor Author

@jcouv @chsienki @CyrusNajmabadi for review.

@RikkiGibson RikkiGibson mentioned this pull request Jul 8, 2021
Closed
25 tasks
jcouv
jcouv approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@jcouv jcouv self-assigned this Jul 9, 2021
@RikkiGibson RikkiGibson merged commit 0c92c3f into dotnet:features/FileScopedNamespaces Jul 9, 2021
@RikkiGibson RikkiGibson deleted the fsn-tests branch July 9, 2021 20:20
CyrusNajmabadi
CyrusNajmabadi reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@chsienki chsienki chsienki approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RikkiGibson @CyrusNajmabadi @jcouv @chsienki