Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to handle missing source after a configuration change #54694

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix failure to handle missing source after a configuration change #54694

merged 1 commit into from
Jul 9, 2021

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jul 8, 2021 •
edited by Pilchie
Loading

Fixes AB#1347599

@sharwell sharwell requested a review from a team as a code owner July 8, 2021 22:22
jasonmalinowski
jasonmalinowski approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach seems fine. My initial gut is whether the check should be in the Solution Explorer stuff, but this ensures that the fix applies to all features consistently, which probably matters for other features too that might be showing temporarily stale info.

src/VisualStudio/Core/Def/Implementation/Workspace/VisualStudioDocumentNavigationService.cs
return false;
}

var generatedDocument = project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting in the lines later seems odd here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation was also broken prior to this change, and was out of scope so I left it.

@sharwell sharwell merged commit dd011d6 into dotnet:main Jul 9, 2021
@ghost ghost added this to the Next milestone Jul 9, 2021
@sharwell sharwell deleted the handle-config-change branch July 9, 2021 03:36
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @jasonmalinowski @allisonchou