Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value tracking to fix a number of UI issues. #54838

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

ryzngard
Copy link
Contributor

  • Details pane no longer showing on click
  • Did not support dark theme
  • Switching themes does not update the highlight brush
  • Selection highlight wasn't working for single character items

* Details pane no longer showing on click
* Did not support dark theme
* Switching themes does not update the highlight brush
* Selection highlight wasn't working for single character items
@ryzngard ryzngard requested a review from a team as a code owner July 15, 2021 07:05
@ryzngard ryzngard added the Feature - IDE Value Tracking Work being done for Value Tracking in the IDE label Jul 15, 2021
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may CI be ever in your favor

@ryzngard ryzngard merged commit 9087236 into dotnet:main Jul 15, 2021
@ryzngard ryzngard deleted the issues/value_tracking_themes branch July 15, 2021 19:05
@ghost ghost added this to the Next milestone Jul 15, 2021
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature - IDE Value Tracking Work being done for Value Tracking in the IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants