Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature flag title #54841

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Change feature flag title #54841

merged 1 commit into from
Jul 16, 2021

Conversation

dibarbet
Copy link
Member

was requested by VS core to align with other feature flag names.

@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jul 15, 2021
@dibarbet dibarbet requested a review from a team as a code owner July 15, 2021 17:42
@dibarbet dibarbet changed the title Change feature flag name Change feature flag title Jul 15, 2021
davidwengier
davidwengier approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯\_(ツ)_/¯

davidwengier
davidwengier approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯\_(ツ)_/¯

@davidwengier
Copy link
Contributor

Thanks GitHub!

@dibarbet
Copy link
Member Author

dibarbet commented Jul 16, 2021 •
edited
Loading

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯_(ツ)_/¯

I believe they're reaching out to everyone, so hopefully consistent soon™

@dibarbet dibarbet merged commit 2e52301 into dotnet:main Jul 16, 2021
@ghost ghost added this to the Next milestone Jul 16, 2021
@dibarbet dibarbet deleted the update_flag_title branch July 16, 2021 07:39
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.
3 participants
@dibarbet @davidwengier @allisonchou