Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MakeTypeAbstract to preserve existing modifiers #54905

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Fix MakeTypeAbstract to preserve existing modifiers #54905

merged 2 commits into from
Jul 19, 2021

Conversation

davidwengier
Copy link
Contributor

Fixes #54218

@davidwengier davidwengier requested a review from a team as a code owner July 18, 2021 12:37
@davidwengier davidwengier mentioned this pull request Jul 18, 2021
Closed
@davidwengier davidwengier merged commit 5f4a192 into dotnet:main Jul 19, 2021
@davidwengier davidwengier deleted the FixMakeTypeAbstract branch July 19, 2021 19:58
@ghost ghost added this to the Next milestone Jul 19, 2021
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.

Make class abstract doesn't preserve modifiers
4 participants
@davidwengier @CyrusNajmabadi @Youssef1313 @allisonchou