Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeSymbol.cs/IsTupleTypeOfCardinality internal #54911

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Make TypeSymbol.cs/IsTupleTypeOfCardinality internal #54911

merged 1 commit into from
Jul 19, 2021

Conversation

AndreyTretyak
Copy link
Contributor

Fixes #48291
IsTupleTypeOfCardinality already could be used only internally, so it's just to reduce future questions.

@AndreyTretyak AndreyTretyak requested a review from a team as a code owner July 19, 2021 00:42
333fred
333fred approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler for a second review. Edit: I didn't see that Rikki had already approved.

@333fred 333fred enabled auto-merge (squash) July 19, 2021 01:52
@333fred 333fred merged commit 6453b4f into dotnet:main Jul 19, 2021
@ghost ghost added this to the Next milestone Jul 19, 2021
@333fred
Copy link
Member

333fred commented Jul 19, 2021

Thanks @AndreyTretyak!

@AndreyTretyak AndreyTretyak deleted the dev/andreyt/48291-typesymbol-method-internal branch July 19, 2021 10:05
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.

TypeSymbol.cs and TypeSymbol.vb are out-of-sync
4 participants
@AndreyTretyak @333fred @RikkiGibson @allisonchou