Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'simplify type names' with file scoped namespaces #54965

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Fix 'simplify type names' with file scoped namespaces #54965

merged 5 commits into from
Jul 20, 2021

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jul 20, 2021 •
edited by jcouv
Loading

Relates to test plan: #49000

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 20, 2021 01:06
davidwengier
davidwengier approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed these commits in #54966

@CyrusNajmabadi CyrusNajmabadi merged commit 21d77e7 into dotnet:main Jul 20, 2021
@ghost ghost added this to the Next milestone Jul 20, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the fileScopedNamespacesSimplifyTypeNames branch July 21, 2021 02:50
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-IDE New Language Feature - File Scoped Namespaces
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @davidwengier @jinujoseph @allisonchou