Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of cloudcache lib we reference #55016

Merged
merged 5 commits into from
Jul 24, 2021

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #54869

}

private const int Iterations = 100;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: even running all tests 100 times each, we still run all sqlite and cloudcache tests in under 30s total. so this seems worth it for the coverage.

@@ -116,7 +116,7 @@
<MicrosoftServiceHubClientVersion>2.8.10</MicrosoftServiceHubClientVersion>
<MicrosoftServiceHubFrameworkVersion>2.8.10</MicrosoftServiceHubFrameworkVersion>
<MicrosoftVisualBasicVersion>10.1.0</MicrosoftVisualBasicVersion>
<MicrosoftVisualStudioCacheVersion>16.10.40-alpha</MicrosoftVisualStudioCacheVersion>
<MicrosoftVisualStudioCacheVersion>17.0.13-alpha</MicrosoftVisualStudioCacheVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to go into main-vs-deps unless we're shipping this in VS, I don't think we've merged dev17 back into main yet (though hopefully soon)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main-vs-deps already has this. this is to unblock main through from teh test failures we're seeing there. do you know when we're going to be on dev17 for main? @jinujoseph ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're waiting on preview2 images? @allisonchou was working on it actively if I remember right

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibarbet can this be merged in now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think so!

@CyrusNajmabadi CyrusNajmabadi merged commit b60fe7f into dotnet:main Jul 24, 2021
@ghost ghost added this to the Next milestone Jul 24, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the updateVersion2 branch July 24, 2021 00:26
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants