Fixes #49529 - Where on CSharp Scripting Environment compiler couldn't determine the 'var' type on the new switch style #55017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ExecutableBinder on chain
ProIcons
changed the title
|
Please add tests for this fix 🙂 |
333fred
reviewed
Jul 21, 2021
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberFieldSymbol.cs
Outdated
Show resolved
Hide resolved
|
|
333fred
reviewed
Jul 21, 2021
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberFieldSymbol.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jul 21, 2021
| @@ -481,7 +481,8 @@ internal sealed override TypeWithAnnotations GetFieldType(ConsList<FieldSymbol> | |||
| fieldsBeingBound = new ConsList<FieldSymbol>(this, fieldsBeingBound); | |||
|
|
|||
| var initializerBinder = new ImplicitlyTypedFieldBinder(binder, fieldsBeingBound); | |||
| var initializerOpt = initializerBinder.BindInferredVariableInitializer(diagnostics, RefKind.None, (EqualsValueClauseSyntax)declarator.Initializer, declarator); | |||
| var executableBinder = new ExecutableCodeBinder((EqualsValueClauseSyntax)declarator.Initializer, this, initializerBinder); | |||
There was a problem hiding this comment.
For future compiler team reviewers, this matches non-inferred variable binding: https://sourceroslyn.io/#Microsoft.CodeAnalysis.CSharp/Binder/Binder_Initializers.cs,312. This path is missing an ExecutableCodeBinder, which means that things like SwitchExpressionBinders aren't created for the code in the initializer. That then causes the null ref in the bug report.
333fred
approved these changes
Jul 21, 2021
|
@dotnet/roslyn-compiler for a second review. |
333fred
added
the
Community
RikkiGibson
approved these changes
Jul 23, 2021
ghost
added this to the
|
Thanks @ProIcons! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49529