Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'match folder and namespace' with file scoped namespaces #55019

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Fix 'match folder and namespace' with file scoped namespaces #55019

merged 2 commits into from
Jul 22, 2021

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jul 21, 2021 •
edited by jcouv
Loading

Relates to test plan: #49000

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 21, 2021 18:54
ryzngard
ryzngard approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dotnet dotnet deleted a comment from azure-pipelines bot Jul 21, 2021
@CyrusNajmabadi
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@CyrusNajmabadi CyrusNajmabadi merged commit 57f6e21 into dotnet:main Jul 22, 2021
@ghost ghost added this to the Next milestone Jul 22, 2021
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the fileScopedNamespaceMatchFolder branch September 30, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE New Language Feature - File Scoped Namespaces
Projects
None yet
Milestone
17.0.P3
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @ryzngard @jcouv @allisonchou