Add template for insertion creation and use for pr val #55094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
dev/dibarbet/insertion_template
branch
from
6d35f42 to
8f85797
Compare
dibarbet
force-pushed
the
dev/dibarbet/insertion_template
branch
from
daf7b75 to
55f4995
Compare
dibarbet
force-pushed
the
dev/dibarbet/insertion_template
branch
from
55f4995 to
112f8b8
Compare
JoeRobich
reviewed
Jul 26, 2021
dibarbet
force-pushed
the
dev/dibarbet/insertion_template
branch
from
218c2d1 to
ea39faf
Compare
dibarbet
force-pushed
the
dev/dibarbet/insertion_template
branch
from
a3f7f7c to
59ce49a
Compare
JoeRobich
reviewed
Jul 28, 2021
JoeRobich
reviewed
Jul 28, 2021
RikkiGibson
approved these changes
Jul 28, 2021
eng/pipelines/insert.yml
Outdated
| @@ -0,0 +1,169 @@ | |||
| parameters: | |||
| # These are actually a booleans but must be defined as string. | |||
There was a problem hiding this comment.
nit: "These are actually booleans"
JoeRobich
approved these changes
Jul 28, 2021
JoeRobich
reviewed
Jul 28, 2021
Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing signed build - https://dev.azure.com/dnceng/internal/_build/results?buildId=1264591&view=results
Passing PR val build - https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5032182&view=results