Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit EnC info for methods with no sequence points #55407

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Emit EnC info for methods with no sequence points #55407

merged 6 commits into from
Aug 12, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 4, 2021 •
edited
Loading

Fixes #55381

@tmat tmat requested a review from a team as a code owner August 4, 2021 19:07
@tmat
Copy link
Member Author

tmat commented Aug 4, 2021

@davidwengier @dotnet/roslyn-compiler PTAL

@lambdageek
Copy link
Member

Can this be merged?

@jaredpar
Copy link
Member

@dotnet/roslyn-compiler PTAL (@cston)

cston
cston approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only.

@tmat tmat enabled auto-merge (squash) August 11, 2021 16:29
@tmat tmat disabled auto-merge August 11, 2021 16:30
@RikkiGibson RikkiGibson self-assigned this Aug 11, 2021
@tmat tmat merged commit d87afc9 into dotnet:main Aug 12, 2021
@ghost ghost added this to the Next milestone Aug 12, 2021
@tmat tmat deleted the EmitEncInfoForHiddenMethods branch August 12, 2021 16:02
This was referenced Aug 13, 2021
Closed
Closed
Closed
@lambdageek lambdageek mentioned this pull request Aug 13, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Aug 16, 2021
Closed
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wincell10 Wincell10 Wincell10 approved these changes

@cston cston cston approved these changes

@davidwengier davidwengier davidwengier approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Interactive
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.

#line hidden directive disables "EnC Lambda and Closure Map" PDB rows
8 participants
@tmat @lambdageek @jaredpar @davidwengier @cston @Wincell10 @dibarbet @RikkiGibson