Bug fix extract local function errors C#7 and below

[akhera99]

Fixes: #55031

Opts to capture variables instead of creating new parameters in language versions below c#8 because they do not support static local functions.

• Need to fix the call to the new method

[MaStr11]

I started to work on this in #55135 and the proposed solution was to capture or to rename the parameters.

#55135 (comment)

[MaStr11]

@akhera99 If you struggle to find a way to identify a linq range variable: I would suggest adding a property to VariableSymbol:

protected abstract class VariableSymbol
{
    public abstract bool CanBeCapturedByLocalFunction { get; }
}

This should return false in QueryVariableSymbol and true in any other case.

You can expose CanBeCapturedByLocalFunction like so in VariableInfo:

protected class VariableInfo
{
            /// <summary>
            /// Returns true, if the variable could be either passed as a parameter
            /// to the new local function or the local function can capture the variable.
            /// </summary>
            public bool CanBeCapturedByLocalFunction
                => _variableSymbol.CanBeCapturedByLocalFunction;
}

[akhera99]

@akhera99 If you struggle to find a way to identify a linq range variable: I would suggest adding a property to VariableSymbol:

protected abstract class VariableSymbol
{
    public abstract bool CanBeCapturedByLocalFunction { get; }
}

This should return false in QueryVariableSymbol and true in any other case.

You can expose CanBeCapturedByLocalFunction like so in VariableInfo:

protected class VariableInfo
{
            /// <summary>
            /// Returns true, if the variable could be either passed as a parameter
            /// to the new local function or the local function can capture the variable.
            /// </summary>
            public bool CanBeCapturedByLocalFunction
                => _variableSymbol.CanBeCapturedByLocalFunction;
}

Thank you for your help. I was trying to avoid looking explicitly at the AnalyzerResult information, but that is definitely the easiest way to handle it.