Run dotnet-format on Roslyn #55679
Merged
Run dotnet-format on Roslyn #55679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Aug 17, 2021
davidwengier
approved these changes
Aug 17, 2021
JoeRobich
reviewed
Aug 18, 2021
| @@ -3650,7 +3650,7 @@ private void AddSynthesizedRecordMembersIfNecessary(MembersAndInitializersBuilde | |||
| memberNames.Free(); | |||
|
|
|||
| // Synthesizing non-readonly properties in struct would require changing readonly logic for PrintMembers method synthesis | |||
| Debug.Assert(isRecordClass || !members.Any(m => m is PropertySymbol { GetMethod.IsEffectivelyReadOnly : false })); | |||
| Debug.Assert(isRecordClass || !members.Any(m => m is PropertySymbol { GetMethod.IsEffectivelyReadOnly: false })); | |||
There was a problem hiding this comment.
This change was made in a separate PR that bumps the CodeStyle analyzers that are used in Roslyn (See https://github.com/dotnet/roslyn/pull/55646/files#diff-d8309181586dfce90074c20deb6e6bc4bf23ae0cf0b9c02b850ee1f9ee055091R3653)
There was a problem hiding this comment.
Merged from main and rerun with latest
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jcouv
approved these changes
Aug 21, 2021
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@ryzngard This can be merged with single compiler review since no code change. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes from running
dotnet-formaton Roslyn.Version of dotnet-format run: 6.0.240501