Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the head of inheritance margin background to InActiveTextBox #55710

Merged

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Aug 18, 2021

Current problem in blue theme:
image

And I have been searching for a good color from VSSDK fits our needs, the closest look like is TextBoxBackgroundDisabledBrushKey

Comparision after the change
Blue:
Before:
image
After:
image

Dark:
Before:
image
After:
image

Light:
Before:
image
After:
image

If anyone knows there is a better color or we should define our own color, plz let me know : )

@Cosifne Cosifne merged commit a6a1658 into dotnet:main Aug 20, 2021
@ghost ghost added this to the Next milestone Aug 20, 2021
@Cosifne Cosifne deleted the dev/shech/InheritanceMarginBlueBackgroundFix branch August 20, 2021 06:16
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants