Region analysis of nameof #55724
Merged
Region analysis of nameof #55724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
reviewed
Aug 19, 2021
| @@ -35071,7 +35071,7 @@ public static void Main(string[] args) | |||
| var decl = GetOutVarDeclaration(tree, name); | |||
| var refs = GetReferences(tree, name).ToArray(); | |||
| Assert.Equal(2, refs.Length); | |||
| VerifyModelForOutVar(model, decl, refs[0]); | |||
| VerifyModelForOutVar(model, decl, isDelegateCreation: false, isExecutableCode: false, isShadowed: false, references: refs[0]); | |||
There was a problem hiding this comment.
Could you please clarify what the significance of this change is?
There was a problem hiding this comment.
The isExecutableCode: false is not the default for overload with fewer parameters. Here's what that drives:
if (isExecutableCode)
{
Assert.True(dataFlow.Succeeded);
Assert.True(dataFlow.VariablesDeclared.Contains(symbol, ReferenceEqualityComparer.Instance));
if (!isDelegateCreation)
{
Assert.True(dataFlow.AlwaysAssigned.Contains(symbol, ReferenceEqualityComparer.Instance));
Assert.True(dataFlow.WrittenInside.Contains(symbol, ReferenceEqualityComparer.Instance));
var flowsIn = FlowsIn(dataFlowParent, decl, references);
Assert.Equal(flowsIn,
dataFlow.DataFlowsIn.Contains(symbol, ReferenceEqualityComparer.Instance));
Assert.Equal(flowsIn,
dataFlow.ReadInside.Contains(symbol, ReferenceEqualityComparer.Instance));
Assert.Equal(FlowsOut(dataFlowParent, decl, references),
dataFlow.DataFlowsOut.Contains(symbol, ReferenceEqualityComparer.Instance));
Assert.Equal(ReadOutside(dataFlowParent, references),
dataFlow.ReadOutside.Contains(symbol, ReferenceEqualityComparer.Instance));
Assert.Equal(WrittenOutside(dataFlowParent, references),
dataFlow.WrittenOutside.Contains(symbol, ReferenceEqualityComparer.Instance));
}
}
|
This is a situation where the IDE shows a variable as being captured but it isn't actually lowered into a field on a closure class, so it ends up being misleading for users. |
|
@dotnet/roslyn-compiler for review. Small fix. Thanks |
RikkiGibson
approved these changes
Aug 20, 2021
|
@jcouv I assume we have tests that cover the examples you put in #53591 (comment)? |
Yes. Those tests existed already in various shapes. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53591