Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnC - Test mixed declaration in deconstruction #55804

Merged
merged 1 commit into from
Aug 24, 2021
Merged

EnC - Test mixed declaration in deconstruction #55804

merged 1 commit into from
Aug 24, 2021

Conversation

davidwengier
Copy link
Contributor

Fixes #50901

@davidwengier davidwengier requested a review from a team as a code owner August 23, 2021 02:29
ryzngard
ryzngard approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tmat
tmat approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit c80e3f8 into dotnet:main Aug 24, 2021
@davidwengier davidwengier deleted the EnCMixedDeconstruction branch August 24, 2021 20:48
@ghost ghost added this to the Next milestone Aug 24, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-IDE Interactive-EnC
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.

EnC: validate mixed declarations and variables in deconstruction
4 participants
@davidwengier @tmat @ryzngard @dibarbet