Bulk update project when several documents change #55813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -356,6 +361,14 @@ private async Task<Project> UpdateProjectInfoAsync(Project project, Checksum inf | |||
| var oldMap = await GetDocumentMapAsync(existingTextDocumentStates, olds.Object).ConfigureAwait(false); | |||
| var newMap = await GetDocumentMapAsync(_assetProvider, news.Object).ConfigureAwait(false); | |||
|
|
|||
| // If more than two documents changed during a single update, perform a bulk synchronization on the | |||
There was a problem hiding this comment.
looks fine with me. do we have any explicit tests where we resync with multiple files changing just to ensure that nothing breaks with this?
There was a problem hiding this comment.
➡️ A test is now added. I verified under debugger that the test goes through the new path.
CyrusNajmabadi
approved these changes
Aug 23, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the active solution configuration, all the documents in the solution change making for a very slow incremental update. This change detects "large" changes within a project as those touching three or more documents in a single operation, and ensures the assets are synchronized in bulk for this case.
Total StreamJsonRpc time prior to this change is 18.4 seconds in response to a configuration change (3138 GetAssetsAsync operations). Total time after this change is 6.5 seconds (1201 GetAssetsAsync operations).
Fixes AB#1365014